Wait for Account proofs blocks if they are not available yet #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdanielh
reviewed
Nov 26, 2024
paberr
reviewed
Nov 26, 2024
|
Added a comment, but generally looks good. |
jsdanielh
force-pushed
the
nibhar/account-proofs
branch
2 times, most recently
from
4bea92c to
b415376
Compare
nibhar
force-pushed
the
nibhar/account-proofs
branch
2 times, most recently
from
d613688 to
220a6b7
Compare
|
Signing commit |
jsdanielh
force-pushed
the
nibhar/account-proofs
branch
from
220a6b7 to
5720cf2
Compare
Wait for a set amount of events only Also continue with the next peer if it fails for the first peer instead of returning from the function.
jsdanielh
force-pushed
the
nibhar/account-proofs
branch
from
5720cf2 to
3936e2f
Compare
hrxi
added a commit
that referenced
this pull request
Nov 26, 2024
Previously, the function would try to block the whole thread whenever requesting something from other peers. This wasn't noticed since the implementation is only used in light clients that were **NOT** compiled for WASM. I noticed this implementation when reviewing #3159, which would have caused these thread blockings to continue for longer times.
hrxi
added a commit
that referenced
this pull request
Nov 26, 2024
Previously, the function would try to block the whole thread whenever requesting something from other peers. This wasn't noticed since the implementation is only used in light clients that were **NOT** compiled for WASM. I noticed this implementation when reviewing #3159, which would have caused these thread blockings to continue for longer times.
hrxi
added a commit
that referenced
this pull request
Nov 27, 2024
Previously, the function would try to block the whole thread whenever requesting something from other peers. This wasn't noticed since the implementation is only used in light clients that were **NOT** compiled for WASM. I noticed this implementation when reviewing #3159, which would have caused these thread blockings to continue for longer times.
|
core-rs-albatross/web-client/src/client/lib.rs Lines 1177 to 1195 in c801676 |
|
Ah, stupid me. That while loop is for the tx listener, not for account proofs 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting the trie in the RemoteDataStore previous to this PR the block which is referenced by the returned proof must already exist locally. That is by no means guaranteed and will result in discarding the proof.
This PR thus added a waiting window within which the RemoteDataStore will wait for the block to arrive. It will wait a specified amount of blockchain events which have added blocks.
Additionally whenever a proof would not verify another peer will be asked to proof an address, whereas before this PR the get_trie would simply fail at this point.
A button was added to the web client example to exercise the behaviour.